diff options
author | Mika Westerberg <mika.westerberg@linux.intel.com> | 2012-04-16 12:48:40 +0400 |
---|---|---|
committer | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-05-05 16:35:47 +0400 |
commit | d72bade76d11da661d76aec5801567d573f39fea (patch) | |
tree | 674cc60de51bb548dbb590fdc7b4d911822d83b9 /drivers/power/charger-manager.c | |
parent | 055d7f0f29b2af6ec8fd5da9f0ce27b9e9e63436 (diff) | |
download | linux-d72bade76d11da661d76aec5801567d573f39fea.tar.xz |
smb347-charger: Move IRQ enabling to the end of probe
There is a potential problem if we call smb347_irq_enable() from
smb347_irq_init() because smb347_irq_enable() makes the device registers
read-only once it returns and smb347_irq_init() expects them to still be
read-write. Currently no harm happens because it is the last call we make
in smb347_irq_init().
Anyway a better place for enabling IRQs is at the end of probe function
and this is also symmetric to call smb347_irq_disable() which is done at
the beginning of remove function.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Diffstat (limited to 'drivers/power/charger-manager.c')
0 files changed, 0 insertions, 0 deletions