diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-08-19 12:44:22 +0400 |
|---|---|---|
| committer | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-08-23 05:47:51 +0400 |
| commit | 05cdbdb95f98fcd080e7494f7d0ca4886aed3c64 (patch) | |
| tree | 061a8bfbbf9386a553b89349f13e23d54744374b /drivers/power/ab8500_btemp.c | |
| parent | 588d4f0b05c9bb09c2474460be78f41813b2d861 (diff) | |
| download | linux-05cdbdb95f98fcd080e7494f7d0ca4886aed3c64.tar.xz | |
ab8500_btemp: Fix error return code
Initialize return variable before exiting on an error path.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Diffstat (limited to 'drivers/power/ab8500_btemp.c')
| -rw-r--r-- | drivers/power/ab8500_btemp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/power/ab8500_btemp.c b/drivers/power/ab8500_btemp.c index bba3ccac72fe..2b76943ff9cf 100644 --- a/drivers/power/ab8500_btemp.c +++ b/drivers/power/ab8500_btemp.c @@ -1014,6 +1014,7 @@ static int __devinit ab8500_btemp_probe(struct platform_device *pdev) create_singlethread_workqueue("ab8500_btemp_wq"); if (di->btemp_wq == NULL) { dev_err(di->dev, "failed to create work queue\n"); + ret = -ENOMEM; goto free_device_info; } |