diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2023-04-17 00:28:38 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2023-04-17 13:23:26 +0300 |
| commit | 02377e983e22396e52d43c4d0adb9bbc85fa9a26 (patch) | |
| tree | 0b0c32005f9f71919135d0d9f9ba6867ea0a6a91 /drivers/platform | |
| parent | 3a133f7c51b20d5d330d5424f3ef0dc283992500 (diff) | |
| download | linux-02377e983e22396e52d43c4d0adb9bbc85fa9a26.tar.xz | |
platform/x86: x86-android-tablets: Update Yoga Book HiDeep touchscreen comment
After recent i2c-hid-of changes, the i2c-hid-of driver could be used
for the Yoga Book HiDeep touchscreen comment instead of the native hideep
driver. Update the comment to reflect this.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20230416212841.311152-1-hdegoede@redhat.com
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/x86/x86-android-tablets/lenovo.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/platform/x86/x86-android-tablets/lenovo.c b/drivers/platform/x86/x86-android-tablets/lenovo.c index a571dcd11544..b5dd74bf9e8c 100644 --- a/drivers/platform/x86/x86-android-tablets/lenovo.c +++ b/drivers/platform/x86/x86-android-tablets/lenovo.c @@ -41,10 +41,13 @@ static struct lp855x_platform_data lenovo_lp8557_pdata = { /* Lenovo Yoga Book X90F / X90L's Android factory img has everything hardcoded */ /* - * The HiDeep IST940E touchscreen comes up in HID mode and could alternatively - * be used in I2C-HID mode (I2C-HID descriptor reg 0x0020) if i2c-hid-of.c is - * modified to use generic (non-OF) device-properties and thought to deal with - * the reset GPIO. "hideep,force-native-protocol" resets it to native mode. + * The HiDeep IST940E touchscreen comes up in I2C-HID mode. The native protocol + * reports ABS_MT_PRESSURE and ABS_MT_TOUCH_MAJOR which are not reported in HID + * mode, so using native mode is preferred. + * It could alternatively be used in HID mode by changing the properties to: + * PROPERTY_ENTRY_U32("hid-descr-addr", 0x0020), + * PROPERTY_ENTRY_U32("post-reset-deassert-delay-ms", 120), + * and changing board_info.type to "hid-over-i2c". */ static const struct property_entry lenovo_yb1_x90_hideep_ts_props[] = { PROPERTY_ENTRY_U32("touchscreen-size-x", 1200), |