diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2017-02-02 20:54:27 +0300 |
|---|---|---|
| committer | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2017-02-14 01:39:49 +0300 |
| commit | 5cb44ee2f4dde68d83a3e17c3333bc4099003669 (patch) | |
| tree | 2818c9f70e09de68b38c56fd068c27ae39beef19 /drivers/platform/x86 | |
| parent | b30f3f8e109698f79ab1cdd30d6386d92338eb15 (diff) | |
| download | linux-5cb44ee2f4dde68d83a3e17c3333bc4099003669.tar.xz | |
platform/x86: intel_mid_powerbtn: Move comment to where it belongs
The comments is about initial interrupt acknowledgment only. So, move it
back to where it belongs.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Diffstat (limited to 'drivers/platform/x86')
| -rw-r--r-- | drivers/platform/x86/intel_mid_powerbtn.c | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/drivers/platform/x86/intel_mid_powerbtn.c b/drivers/platform/x86/intel_mid_powerbtn.c index 594d503ca6fe..de40c71883f8 100644 --- a/drivers/platform/x86/intel_mid_powerbtn.c +++ b/drivers/platform/x86/intel_mid_powerbtn.c @@ -76,16 +76,6 @@ static int mid_pbstat(struct mid_pb_ddata *ddata, int *value) static int mfld_ack(struct mid_pb_ddata *ddata) { - /* - * SCU firmware might send power button interrupts to IA core before - * kernel boots and doesn't get EOI from IA core. The first bit of - * MSIC reg 0x21 is kept masked, and SCU firmware doesn't send new - * power interrupt to Android kernel. Unmask the bit when probing - * power button in kernel. - * There is a very narrow race between irq handler and power button - * initialization. The race happens rarely. So we needn't worry - * about it. - */ return intel_msic_reg_update(INTEL_MSIC_IRQLVL1MSK, 0, MSIC_PWRBTNM); } @@ -202,6 +192,16 @@ static int mid_pb_probe(struct platform_device *pdev) platform_set_drvdata(pdev, ddata); + /* + * SCU firmware might send power button interrupts to IA core before + * kernel boots and doesn't get EOI from IA core. The first bit of + * MSIC reg 0x21 is kept masked, and SCU firmware doesn't send new + * power interrupt to Android kernel. Unmask the bit when probing + * power button in kernel. + * There is a very narrow race between irq handler and power button + * initialization. The race happens rarely. So we needn't worry + * about it. + */ error = ddata->ack(ddata); if (error) { dev_err(&pdev->dev, |