diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-03-16 15:10:15 +0300 |
|---|---|---|
| committer | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2018-04-02 18:28:45 +0300 |
| commit | 0e5b09b165510e2ea5c526e962c4edadd849ef4c (patch) | |
| tree | 6decdb3de5a88a3c5b8eed60b0b7a4d898e5f5e4 /drivers/platform/x86/dell-smbios-base.c | |
| parent | 2b5de0cc1fe0e2308dc1d2494de7917c707bd8ca (diff) | |
| download | linux-0e5b09b165510e2ea5c526e962c4edadd849ef4c.tar.xz | |
platform/x86: dell-smbios: Fix memory leaks in build_tokens_sysfs()
We're freeing "value_name" which is NULL, so that's a no-op, but we
intended to free "location_name" instead. And then we don't free the
names in token_location_attrs[0] and token_value_attrs[0].
Fixes: 33b9ca1e53b4 ("platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Diffstat (limited to 'drivers/platform/x86/dell-smbios-base.c')
| -rw-r--r-- | drivers/platform/x86/dell-smbios-base.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c index 2485c80a9fdd..33fb2a20458a 100644 --- a/drivers/platform/x86/dell-smbios-base.c +++ b/drivers/platform/x86/dell-smbios-base.c @@ -514,7 +514,7 @@ static int build_tokens_sysfs(struct platform_device *dev) continue; loop_fail_create_value: - kfree(value_name); + kfree(location_name); goto out_unwind_strings; } smbios_attribute_group.attrs = token_attrs; @@ -525,7 +525,7 @@ loop_fail_create_value: return 0; out_unwind_strings: - for (i = i-1; i > 0; i--) { + while (i--) { kfree(token_location_attrs[i].attr.name); kfree(token_value_attrs[i].attr.name); } |