summaryrefslogtreecommitdiff
path: root/drivers/platform/x86/asus-laptop.c
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@gmail.com>2010-07-21 02:19:47 +0400
committerMatthew Garrett <mjg@redhat.com>2010-08-03 17:49:01 +0400
commit9fb866f317def195bb794120e13d1d73c2a94bb2 (patch)
treebc6f8fef9ddcb76db8e3db97f108c6dc5aa5d743 /drivers/platform/x86/asus-laptop.c
parente38f052ba5fd4d3d8eb547e7d0c6bc1143a2babd (diff)
downloadlinux-9fb866f317def195bb794120e13d1d73c2a94bb2.tar.xz
asus-laptop: fix incorrect return value for write_acpi_int_ret if handle is NULL
According to the comments of write_acpi_int_ret(), write_acpi_int_ret() should return 0 if write is successful, -1 else. Thus if handle is NULL, the write does not happen, it should return -1. Signed-off-by: Axel Lin <axel.lin@gmail.com> Cc: Matthew Garrett <mjg@redhat.com> Cc: Corentin Chary <corentincj@iksaif.net> Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Matthew Garrett <mjg@redhat.com>
Diffstat (limited to 'drivers/platform/x86/asus-laptop.c')
-rw-r--r--drivers/platform/x86/asus-laptop.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index 4af5709f8317..19445eaff6ff 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -297,7 +297,7 @@ static int write_acpi_int_ret(acpi_handle handle, const char *method, int val,
acpi_status status;
if (!handle)
- return 0;
+ return -1;
params.count = 1;
params.pointer = &in_obj;