diff options
| author | Felix Gu <ustc.gu@gmail.com> | 2026-01-26 19:35:47 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-04-02 14:23:02 +0300 |
| commit | 7068aaa1cef4e23504e376f6eb2682df7487258a (patch) | |
| tree | c1bf23a992ebc2dcf9d90be5d298360d8994ab3d /drivers/pinctrl | |
| parent | 88d386243ed374ac969dabd3bbc1409a31d81818 (diff) | |
| download | linux-7068aaa1cef4e23504e376f6eb2682df7487258a.tar.xz | |
pinctrl: renesas: rzt2h: Fix device node leak in rzt2h_gpio_register()
[ Upstream commit e825c79ef914bd55cf7c2476ddcfb2738eb689c3 ]
When calling of_parse_phandle_with_fixed_args(), the caller is
responsible for calling of_node_put() to release the device node
reference.
In rzt2h_gpio_register(), the driver fails to call of_node_put() to
release the reference in of_args.np, which causes a memory leak.
Add the missing of_node_put() call to fix the leak.
Fixes: 34d4d093077a ("pinctrl: renesas: Add support for RZ/T2H")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://patch.msgid.link/20260127-rzt2h-v1-1-86472e7421b8@gmail.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/renesas/pinctrl-rzt2h.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pinctrl/renesas/pinctrl-rzt2h.c b/drivers/pinctrl/renesas/pinctrl-rzt2h.c index 3161b2469c36..595ad5c83aa0 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzt2h.c +++ b/drivers/pinctrl/renesas/pinctrl-rzt2h.c @@ -648,6 +648,7 @@ static int rzt2h_gpio_register(struct rzt2h_pinctrl *pctrl) if (ret) return dev_err_probe(dev, ret, "Unable to parse gpio-ranges\n"); + of_node_put(of_args.np); if (of_args.args[0] != 0 || of_args.args[1] != 0 || of_args.args[2] != pctrl->data->n_port_pins) return dev_err_probe(dev, -EINVAL, |