diff options
author | Doug Anderson <dianders@chromium.org> | 2014-11-20 01:51:33 +0300 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2014-12-30 15:17:27 +0300 |
commit | f2dd028c2632d107c26b1daed543d9efd4f0decd (patch) | |
tree | bcdd09a8392ca258ef81eac43c1a486f65e79272 /drivers/pinctrl/pinctrl-st.c | |
parent | 68bda47c57c9d671820672badc1cb62211ec4700 (diff) | |
download | linux-f2dd028c2632d107c26b1daed543d9efd4f0decd.tar.xz |
pinctrl: rockchip: Fix enable/disable/mask/unmask
The Rockchip pinctrl driver was only implementing the "mask" and
"unmask" operations though the hardware actually has two distinct
things: enable/disable and mask/unmask. It was implementing the
"mask" operations as a hardware enable/disable and always leaving all
interrupts unmasked.
I believe that the old system had some downsides, specifically:
- (Untested) if an interrupt went off while interrupts were "masked"
it would be lost. Now it will be kept track of.
- If someone wanted to change an interrupt back into a GPIO (is such a
thing sensible?) by calling irq_disable() it wouldn't actually take
effect. That's because Linux does some extra optimizations when
there's no true "disable" function: it does a lazy mask.
Let's actually implement enable/disable/mask/unmask properly.
Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-st.c')
0 files changed, 0 insertions, 0 deletions