diff options
author | Nathan Chancellor <natechancellor@gmail.com> | 2018-11-01 03:44:10 +0300 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2018-11-09 12:20:47 +0300 |
commit | 957063c924736d4341e5d588757b9f31e8f6fa24 (patch) | |
tree | 7dcece89f5f95a397af1427e9a047bc70a159712 /drivers/pinctrl/bcm/pinctrl-bcm2835.c | |
parent | 1f60652dd586d1b3eee7c4602892a97a62fa937a (diff) | |
download | linux-957063c924736d4341e5d588757b9f31e8f6fa24.tar.xz |
pinctrl: sprd: Use define directive for sprd_pinconf_params values
Clang warns when one enumerated type is implicitly converted to another:
drivers/pinctrl/sprd/pinctrl-sprd.c:845:19: warning: implicit conversion
from enumeration type 'enum sprd_pinconf_params' to different
enumeration type 'enum pin_config_param' [-Wenum-conversion]
{"sprd,control", SPRD_PIN_CONFIG_CONTROL, 0},
~ ^~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/sprd/pinctrl-sprd.c:846:22: warning: implicit conversion
from enumeration type 'enum sprd_pinconf_params' to different
enumeration type 'enum pin_config_param' [-Wenum-conversion]
{"sprd,sleep-mode", SPRD_PIN_CONFIG_SLEEP_MODE, 0},
~ ^~~~~~~~~~~~~~~~~~~~~~~~~~
It is expected that pinctrl drivers can extend pin_config_param because
of the gap between PIN_CONFIG_END and PIN_CONFIG_MAX so this conversion
isn't an issue. Most drivers that take advantage of this define the
PIN_CONFIG variables as constants, rather than enumerated values. Do the
same thing here so that Clang no longer warns.
Link: https://github.com/ClangBuiltLinux/linux/issues/138
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/bcm/pinctrl-bcm2835.c')
0 files changed, 0 insertions, 0 deletions