diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2019-09-04 14:40:14 +0300 |
|---|---|---|
| committer | Kishon Vijay Abraham I <kishon@ti.com> | 2019-10-31 14:24:01 +0300 |
| commit | 82b5d164415549e74cfa1f9156ffd4463d0a76e2 (patch) | |
| tree | aa668ea9bf6f11d2daf8e967c77319f7b2e67d06 /drivers/phy/lantiq | |
| parent | 3817c79611792333a33f6548a2aaf701a70fc593 (diff) | |
| download | linux-82b5d164415549e74cfa1f9156ffd4463d0a76e2.tar.xz | |
phy: lantiq: vrx200-pcie: fix error return code in ltq_vrx200_pcie_phy_power_on()
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: e52a632195bf ("phy: lantiq: vrx200-pcie: add a driver for the Lantiq VRX200 PCIe PHY")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy/lantiq')
| -rw-r--r-- | drivers/phy/lantiq/phy-lantiq-vrx200-pcie.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/phy/lantiq/phy-lantiq-vrx200-pcie.c b/drivers/phy/lantiq/phy-lantiq-vrx200-pcie.c index 544d64a84cc0..6e457967653e 100644 --- a/drivers/phy/lantiq/phy-lantiq-vrx200-pcie.c +++ b/drivers/phy/lantiq/phy-lantiq-vrx200-pcie.c @@ -323,7 +323,8 @@ static int ltq_vrx200_pcie_phy_power_on(struct phy *phy) goto err_disable_pdi_clk; /* Check if we are in "startup ready" status */ - if (ltq_vrx200_pcie_phy_wait_for_pll(phy) != 0) + ret = ltq_vrx200_pcie_phy_wait_for_pll(phy); + if (ret) goto err_disable_phy_clk; ltq_vrx200_pcie_phy_apply_workarounds(phy); |