diff options
| author | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2020-05-17 20:29:57 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-07-22 10:22:24 +0300 |
| commit | 89922d5f2ee2696943635e3c8fd6fce71ce0b11c (patch) | |
| tree | 819f94c9db7b5397992f627c738eef204b5d2a54 /drivers/phy/allwinner/phy-sun4i-usb.c | |
| parent | fdd73b8ef420c4fb7ecd1e45f6e34181b79b2501 (diff) | |
| download | linux-89922d5f2ee2696943635e3c8fd6fce71ce0b11c.tar.xz | |
iio:health:afe4404 Fix timestamp alignment and prevent data leak.
[ Upstream commit f88ecccac4be348bbcc6d056bdbc622a8955c04d ]
One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp assumes the buffer used is aligned
to the size of the timestamp (8 bytes). This is not guaranteed in
this driver which uses a 40 byte array of smaller elements on the stack.
As Lars also noted this anti pattern can involve a leak of data to
userspace and that indeed can happen here. We close both issues by
moving to a suitable structure in the iio_priv() data with alignment
explicitly requested. This data is allocated with kzalloc so no
data can leak appart from previous readings.
Fixes: 87aec56e27ef ("iio: health: Add driver for the TI AFE4404 heart monitor")
Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/phy/allwinner/phy-sun4i-usb.c')
0 files changed, 0 insertions, 0 deletions