diff options
author | David Brownell <david-b@pacbell.net> | 2008-04-14 01:00:44 +0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-04-25 08:16:53 +0400 |
commit | c6dbf554bc8a79c9caab3dbf891a33c19068f646 (patch) | |
tree | be47ae8d24aa2564fd424fecc1ef85e6717dd06d /drivers/pci | |
parent | 08177e12b7b4c3d59060f829e5c151d06f9a08d6 (diff) | |
download | linux-c6dbf554bc8a79c9caab3dbf891a33c19068f646.tar.xz |
USB: cdc-acm: signedness fix
Fix bogus assignment of "unsigned char *" to "char *": preserve
unsignedness. These values are used directly as descriptor lengths
when iterating through the buffer, so this *could* cause oddness
that potentially includes oopsing. (IMO not likely, except as
part of a malicious device...)
Fix the bogus warning in CDC ACM which highlighted this problem
(by showing a negative descriptor type). It uses the undesirable
legacy err() for something that's not even an error; switch to
use dev_dbg, and show descriptor types in hex notation to match
the convention for such codes.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/pci')
0 files changed, 0 insertions, 0 deletions