summaryrefslogtreecommitdiff
path: root/drivers/pci
diff options
context:
space:
mode:
authorDmitry Torokhov <dtor@chromium.org>2014-11-15 01:19:03 +0300
committerBjorn Helgaas <bhelgaas@google.com>2014-12-27 02:23:35 +0300
commitea3651fee6c92a29244830334979396465ed8587 (patch)
treef88ab069f7e2e59dd7fbb9d18168f9547a2b179c /drivers/pci
parent97bf6af1f928216fd6c5a66e8a57bfa95a659672 (diff)
downloadlinux-ea3651fee6c92a29244830334979396465ed8587.tar.xz
PCI: keystone: Fix error handling of irq_of_parse_and_map()
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Acked-By: Murali Karicheri <m-karicheri2@ti.com>
Diffstat (limited to 'drivers/pci')
-rw-r--r--drivers/pci/host/pci-keystone.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
index 78f79e31ac5c..23a1d97db1dd 100644
--- a/drivers/pci/host/pci-keystone.c
+++ b/drivers/pci/host/pci-keystone.c
@@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie,
*/
for (temp = 0; temp < max_host_irqs; temp++) {
host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);
- if (host_irqs[temp] < 0)
+ if (!host_irqs[temp])
break;
}
if (temp) {