diff options
| author | Juergen Gross <jgross@suse.com> | 2016-10-31 16:58:41 +0300 |
|---|---|---|
| committer | Juergen Gross <jgross@suse.com> | 2016-11-07 15:55:26 +0300 |
| commit | 58faf07b76817782ea20c392639569ea613cd439 (patch) | |
| tree | 423bd77b2d62cd6087cbf42d074157abaac49782 /drivers/pci/xen-pcifront.c | |
| parent | 2890ea5c13321d26732c4520649681965480ee1c (diff) | |
| download | linux-58faf07b76817782ea20c392639569ea613cd439.tar.xz | |
xen: make use of xenbus_read_unsigned() in xen-pcifront
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible.
This requires to change the type of the read from int to unsigned,
but this case has been wrong before: negative values are not allowed
for the modified case.
Cc: bhelgaas@google.com
Cc: linux-pci@vger.kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: David Vrabel <david.vrabel@citrix.com>
Diffstat (limited to 'drivers/pci/xen-pcifront.c')
| -rw-r--r-- | drivers/pci/xen-pcifront.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index d6ff5e82377d..8fc2e9532575 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -1038,10 +1038,8 @@ static int pcifront_detach_devices(struct pcifront_device *pdev) err = -ENOMEM; goto out; } - err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend, str, "%d", - &state); - if (err != 1) - state = XenbusStateUnknown; + state = xenbus_read_unsigned(pdev->xdev->otherend, str, + XenbusStateUnknown); if (state != XenbusStateClosing) continue; |