diff options
author | Bjorn Helgaas <bhelgaas@google.com> | 2012-09-21 03:09:48 +0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2012-09-21 03:10:54 +0400 |
commit | 94bb346480f8646871e5547491b5746ae0a643c3 (patch) | |
tree | 56bec45b0079145ea4a0e8aec552ab44dd1f51f9 /drivers/pci/remove.c | |
parent | 9b9a6d261616bed589302bc6244c5bd7c99a733f (diff) | |
download | linux-94bb346480f8646871e5547491b5746ae0a643c3.tar.xz |
Revert "PCI: Use hotplug-safe pci_get_domain_bus_and_slot()"
This reverts commit 433efd2247b0cbf5e7e86275e1f21281d3b99047.
When we remove an SR-IOV device, we have this call chain:
driver .remove() method
pci_disable_sriov()
sriov_disable()
virtfn_remove()
pci_get_domain_bus_and_slot()
sriov_disable() is only called for PFs, not for VFs. When it's called
for a PF, it loops through all the VFs and calls virtfn_remove() for
each. But we stop and remove VFs before PFs, so by the time we get
to virtfn_remove(), the VFs have already been stopped and deleted
from the device list. Now pci_get_domain_bus_and_slot(), which uses
bus_find_device() and relies on that device list, doesn't find the
VFs, so the VF references aren't released correctly.
Reported-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/remove.c')
0 files changed, 0 insertions, 0 deletions