diff options
| author | James Smart <james.smart@broadcom.com> | 2020-09-23 00:54:12 +0300 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2020-09-27 10:14:19 +0300 |
| commit | ddd3d1051797b9f907ab9799f5ba50398c530676 (patch) | |
| tree | 76ec68d1f8dbab151b42f975a1456f42bcb0db2a /drivers/nvme/target/fc.c | |
| parent | 5b3356d9da88fe6d6f3bcd8a2336d14a767f377d (diff) | |
| download | linux-ddd3d1051797b9f907ab9799f5ba50398c530676.tar.xz | |
nvmet-fc: fix missing check for no hostport struct
A hostport port pointer is allowed to be NULL as it is not allocated if
the lldd does not support the new interfaces for NVME LS request support.
The hostport free routine validates the handle but forgot to validate the
hostport pointer.
Validate the hostport pointer before using it to validate the handle.
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme/target/fc.c')
| -rw-r--r-- | drivers/nvme/target/fc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c index e6861cc10e7d..cd4e73aa9807 100644 --- a/drivers/nvme/target/fc.c +++ b/drivers/nvme/target/fc.c @@ -1019,7 +1019,7 @@ static void nvmet_fc_free_hostport(struct nvmet_fc_hostport *hostport) { /* if LLDD not implemented, leave as NULL */ - if (!hostport->hosthandle) + if (!hostport || !hostport->hosthandle) return; nvmet_fc_hostport_put(hostport); |