diff options
| author | Markus Pargmann <mpa@pengutronix.de> | 2013-10-13 23:17:01 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-10-17 23:48:14 +0400 |
| commit | dbbd2ad89bb1f86b94b23bb2e56d4935717f9b94 (patch) | |
| tree | c44747aa07f81d6eb8ff94e3bfc4c2972f40fd90 /drivers/net | |
| parent | 60e66fee56b2256dcb1dc2ea1b2ddcb6e273857d (diff) | |
| download | linux-dbbd2ad89bb1f86b94b23bb2e56d4935717f9b94.tar.xz | |
net/ethernet: cpsw: Bugfix interrupts before enabling napi
If interrupts happen before napi_enable was called, the driver will not
work as expected. Network transmissions are impossible in this state.
This bug can be reproduced easily by restarting the network interface in
a loop. After some time any network transmissions on the network
interface will fail.
This patch fixes the bug by enabling napi before enabling the network
interface interrupts.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/ti/cpsw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 804846eb5fc2..fccd9d4d4ae0 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1169,9 +1169,9 @@ static int cpsw_ndo_open(struct net_device *ndev) } } + napi_enable(&priv->napi); cpdma_ctlr_start(priv->dma); cpsw_intr_enable(priv); - napi_enable(&priv->napi); cpdma_ctlr_eoi(priv->dma, CPDMA_EOI_RX); cpdma_ctlr_eoi(priv->dma, CPDMA_EOI_TX); |