diff options
| author | Stefan Schmidt <stefan@osg.samsung.com> | 2017-09-22 11:44:57 +0300 |
|---|---|---|
| committer | Stefan Schmidt <stefan@osg.samsung.com> | 2017-09-26 16:22:44 +0300 |
| commit | 763556980dde78166886734ae470664c67067dd4 (patch) | |
| tree | f60fdad0a202c04f240c43ecf09355519e8d4878 /drivers/net | |
| parent | 01ccdf126ca5f9d4fe0889f65ee67afac910f19c (diff) | |
| download | linux-763556980dde78166886734ae470664c67067dd4.tar.xz | |
ieee802154: atusb: fix firmware version check to enable frame retries
Geert reported: as fw_ver_maj is unsigned char, gcc 4.1.2 complains:
warning: comparison is always true due to limited range of data type
Besides the warning the old check would also fail for firmware versions
like 1.x with x < 3. These would support frame retries, but the driver
would not enable the feature.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ieee802154/atusb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c index 115fa3f37a86..6b3cdf4bd667 100644 --- a/drivers/net/ieee802154/atusb.c +++ b/drivers/net/ieee802154/atusb.c @@ -1060,7 +1060,7 @@ static int atusb_probe(struct usb_interface *interface, atusb_get_and_show_build(atusb); atusb_set_extended_addr(atusb); - if (atusb->fw_ver_maj >= 0 && atusb->fw_ver_min >= 3) + if ((atusb->fw_ver_maj == 0 && atusb->fw_ver_min >= 3) || atusb->fw_ver_maj > 0) hw->flags |= IEEE802154_HW_FRAME_RETRIES; ret = atusb_get_and_clear_error(atusb); |