diff options
| author | James Hogan <james.hogan@imgtec.com> | 2015-02-21 02:45:44 +0300 |
|---|---|---|
| committer | Wim Van Sebroeck <wim@iguana.be> | 2015-03-27 10:47:42 +0300 |
| commit | a629c08fdb98ebb184d745553af9dda4f05941bf (patch) | |
| tree | 3671a36cf23d6f124b9c6e098f5abefb5004fff8 /drivers/net | |
| parent | 9ffd906d9a6e50c958bd99971d762a426a12a36a (diff) | |
| download | linux-a629c08fdb98ebb184d745553af9dda4f05941bf.tar.xz | |
watchdog: imgpdc: Fix probe NULL pointer dereference
The IMG PDC watchdog probe function calls pdc_wdt_stop() prior to
watchdog_set_drvdata(), causing a NULL pointer dereference when
pdc_wdt_stop() retrieves the struct pdc_wdt_dev pointer using
watchdog_get_drvdata() and reads the register base address through it.
Fix by moving the watchdog_set_drvdata() call earlier, to where various
other pdc_wdt->wdt_dev fields are initialised.
Fixes: 93937669e9b5 ("watchdog: ImgTec PDC Watchdog Timer Driver")
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
Cc: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
Cc: Jude Abraham <Jude.Abraham@imgtec.com>
Cc: linux-watchdog@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/net')
0 files changed, 0 insertions, 0 deletions