summaryrefslogtreecommitdiff
path: root/drivers/net
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-01-30 15:07:06 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-02-06 09:46:32 +0300
commit4c8fc44c44b97854623c56363c359f711fc0b887 (patch)
treec7b452e8241cb1c9dbd8d5f0805c097db22dfe14 /drivers/net
parent744fe9be9665227335539b7a77ece8d9ff62b6c0 (diff)
downloadlinux-4c8fc44c44b97854623c56363c359f711fc0b887.tar.xz
wifi: brcmfmac: fix up incorrect 4.14.y backport for brcmf_fw_map_chip_to_name()
In commit bc45aa1911bf699b9905f12414e3c1879d6b784f which is commit 81d17f6f3331f03c8eafdacea68ab773426c1e3c upstream, the return value of the error condition needs to be reworked to return a real error and not NULL. Reported-by: Nathan Chancellor <nathan@kernel.org> Cc: Dokyung Song <dokyungs@yonsei.ac.kr> Cc: Jisoo Jang <jisoo.jang@yonsei.ac.kr> Cc: Minsuk Kang <linuxlovemin@yonsei.ac.kr> Cc: Kalle Valo <kvalo@kernel.org> Cc: Sasha Levin <sashal@kernel.org> Link: https://lore.kernel.org/r/Y8gccXXyE30sbPSg@dev-arch.thelio-3990X Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
index 6d868b8b441a..da9b94754b73 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
@@ -574,7 +574,7 @@ int brcmf_fw_map_chip_to_name(u32 chip, u32 chiprev,
if (chiprev >= BITS_PER_TYPE(u32)) {
brcmf_err("Invalid chip revision %u\n", chiprev);
- return NULL;
+ return -EINVAL;
}
for (i = 0; i < table_size; i++) {