diff options
| author | Vitaly Kuznetsov <vkuznets@redhat.com> | 2017-05-11 14:58:06 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-05-12 04:38:50 +0300 |
| commit | d86b5672b1adb98b4cdd6fbf0224bbfb03db6e2e (patch) | |
| tree | b16d295eb0fd3a6dbef29514eba363d3b8e82770 /drivers/net/xen-netfront.c | |
| parent | cb395b2010879a8461aa1b1c37025769708c32cf (diff) | |
| download | linux-d86b5672b1adb98b4cdd6fbf0224bbfb03db6e2e.tar.xz | |
xen-netfront: avoid crashing on resume after a failure in talk_to_netback()
Unavoidable crashes in netfront_resume() and netback_changed() after a
previous fail in talk_to_netback() (e.g. when we fail to read MAC from
xenstore) were discovered. The failure path in talk_to_netback() does
unregister/free for netdev but we don't reset drvdata and we try accessing
it after resume.
Fix the bug by removing the whole xen device completely with
device_unregister(), this guarantees we won't have any calls into netfront
after a failure.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/xen-netfront.c')
| -rw-r--r-- | drivers/net/xen-netfront.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 6ffc482550c1..7b61adb6270c 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1934,8 +1934,7 @@ abort_transaction_no_dev_fatal: xennet_disconnect_backend(info); xennet_destroy_queues(info); out: - unregister_netdev(info->netdev); - xennet_free_netdev(info->netdev); + device_unregister(&dev->dev); return err; } |