summaryrefslogtreecommitdiff
path: root/drivers/net/wireless/realtek
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2019-10-25 14:30:56 +0300
committerKalle Valo <kvalo@codeaurora.org>2019-10-31 11:04:55 +0300
commitbaff8da6e1636420ce04cadd6df56e137fa6e005 (patch)
tree64724710e472f2ecb9b0899e19ce0d877b4fa765 /drivers/net/wireless/realtek
parent5195b904264098839144d08d23c600811de2e2da (diff)
downloadlinux-baff8da6e1636420ce04cadd6df56e137fa6e005.tar.xz
rtw88: remove redundant null pointer check on arrays
The checks to see if swing_table->n or swing_table->p are null are redundant since n and p are arrays and can never be null if swing_table is non-null. I believe these are redundant checks and can be safely removed, especially the checks implies that these are not arrays which can lead to confusion. Addresses-Coverity: ("Array compared against 0") Fixes: c97ee3e0bea2 ("rtw88: add power tracking support") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/realtek')
-rw-r--r--drivers/net/wireless/realtek/rtw88/phy.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c
index 4adba44dbd74..a3e1e9578b65 100644
--- a/drivers/net/wireless/realtek/rtw88/phy.c
+++ b/drivers/net/wireless/realtek/rtw88/phy.c
@@ -2059,7 +2059,7 @@ s8 rtw_phy_pwrtrack_get_pwridx(struct rtw_dev *rtwdev,
return 0;
}
- if (!swing_table || !swing_table->n || !swing_table->p) {
+ if (!swing_table) {
rtw_warn(rtwdev, "swing table not configured\n");
return 0;
}