diff options
| author | Lorenzo Bianconi <lorenzo@kernel.org> | 2019-02-21 02:57:19 +0300 |
|---|---|---|
| committer | Felix Fietkau <nbd@nbd.name> | 2019-02-26 14:25:18 +0300 |
| commit | cb1847cce03c9787e888cb545096bd53c702cf20 (patch) | |
| tree | 4f83205946fee631955c4f8a20c63060fd25cde1 /drivers/net/wireless/mediatek | |
| parent | fc994dbbd94e638fbdabb9d8acd965800a6f25dd (diff) | |
| download | linux-cb1847cce03c9787e888cb545096bd53c702cf20.tar.xz | |
mt76: usb: fix warning in mt76u_buf_free
Fix following static checker warning in mt76u_buf_free:
drivers/net/wireless/mediatek/mt76/usb.c:372 mt76u_buf_free()
warn: address of 'urb->sg[i]' is non-NULL
There is no need to check sg page pointer since urb->num_sgs
has been already validated in mt76u_fill_rx_sg
Fixes: cb83585e1121 ("mt76: usb: fix possible memory leak in mt76u_buf_free")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Diffstat (limited to 'drivers/net/wireless/mediatek')
| -rw-r--r-- | drivers/net/wireless/mediatek/mt76/usb.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c index 792f5012f1b1..7cd95f950ca2 100644 --- a/drivers/net/wireless/mediatek/mt76/usb.c +++ b/drivers/net/wireless/mediatek/mt76/usb.c @@ -364,16 +364,11 @@ int mt76u_buf_alloc(struct mt76_dev *dev, struct mt76u_buf *buf, void mt76u_buf_free(struct mt76u_buf *buf) { struct urb *urb = buf->urb; - struct scatterlist *sg; int i; - for (i = 0; i < urb->num_sgs; i++) { - sg = &urb->sg[i]; - if (!sg) - continue; + for (i = 0; i < urb->num_sgs; i++) + skb_free_frag(sg_virt(&urb->sg[i])); - skb_free_frag(sg_virt(sg)); - } if (buf->buf) skb_free_frag(buf->buf); |