diff options
| author | Roopa Prabhu <roopa@cumulusnetworks.com> | 2020-05-29 08:12:35 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-05-31 07:47:08 +0300 |
| commit | 72b4868211a85d040c42444620f2197bb0094ac8 (patch) | |
| tree | 139eca7b006e59b16e7c7a6367ff946c4c059ea1 /drivers/net/vxlan.c | |
| parent | d9f0d6605f30feb2f137d6bc83fcb6c2853e7fd6 (diff) | |
| download | linux-72b4868211a85d040c42444620f2197bb0094ac8.tar.xz | |
vxlan: add check to prevent use of remote ip attributes with NDA_NH_ID
NDA_NH_ID represents a remote ip or a group of remote ips.
It allows use of nexthop groups in lieu of a remote ip or a
list of remote ips supported by the fdb api.
Current code ignores the other remote ip attrs when NDA_NH_ID is
specified. In the spirit of strict checking, This commit adds a
check to explicitly return an error on incorrect usage.
Fixes: 1274e1cc4226 ("vxlan: ecmp support for mac fdb entries")
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/vxlan.c')
| -rw-r--r-- | drivers/net/vxlan.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index a0015cdedfaf..fe606c688855 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1196,6 +1196,10 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan, struct net *net = dev_net(vxlan->dev); int err; + if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] || + tb[NDA_PORT])) + return -EINVAL; + if (tb[NDA_DST]) { err = vxlan_nla_get_addr(ip, tb[NDA_DST]); if (err) |