diff options
| author | yangerkun <yangerkun@huawei.com> | 2020-02-28 16:40:48 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-03-11 09:51:14 +0300 |
| commit | 4b2e97b1409adc49bc6db169f8066d01e79ac4fb (patch) | |
| tree | 7fd4e602fb04d0c35bdb2fa69b502a9c16f323ca /drivers/net/slip | |
| parent | 2f4375851ae216000b61885d28f62bd878b69b83 (diff) | |
| download | linux-4b2e97b1409adc49bc6db169f8066d01e79ac4fb.tar.xz | |
slip: stop double free sl->dev in slip_open
After include 3b5a39979daf ("slip: Fix memory leak in slip_open error path")
and e58c19124189 ("slip: Fix use-after-free Read in slip_open") with 4.4.y/4.9.y.
We will trigger a bug since we can double free sl->dev in slip_open. Actually,
we should backport cf124db566e6 ("net: Fix inconsistent teardown and release
of private netdev state.") too since it has delete free_netdev from sl_free_netdev.
Fix it by delete free_netdev from slip_open.
Signed-off-by: yangerkun <yangerkun@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/slip')
| -rw-r--r-- | drivers/net/slip/slip.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c index 0f8d5609ed51..d4a33baa33b6 100644 --- a/drivers/net/slip/slip.c +++ b/drivers/net/slip/slip.c @@ -868,7 +868,6 @@ err_free_chan: tty->disc_data = NULL; clear_bit(SLF_INUSE, &sl->flags); sl_free_netdev(sl->dev); - free_netdev(sl->dev); err_exit: rtnl_unlock(); |