diff options
| author | Stephen Hemminger <shemminger@linux-foundation.org> | 2007-05-11 22:21:45 +0400 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2007-05-12 01:53:36 +0400 |
| commit | e3b7df17c8344fbcc00e871e03f5f88d58905277 (patch) | |
| tree | a2b1c8e88277c818c12f2bc725cc298f15daa3a9 /drivers/net/skge.c | |
| parent | 549a68c3fe2ca320b0764d1289d17af797daa5d1 (diff) | |
| download | linux-e3b7df17c8344fbcc00e871e03f5f88d58905277.tar.xz | |
skge: crash on shutdown/suspend
If device is not fails during module startup (like unsupported chip
version) then driver would crash dereferencing a null pointer, on shutdown
or suspend/resume.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net/skge.c')
| -rw-r--r-- | drivers/net/skge.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/net/skge.c b/drivers/net/skge.c index e0489578945d..776692946562 100644 --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -3802,6 +3802,9 @@ static int skge_suspend(struct pci_dev *pdev, pm_message_t state) struct skge_hw *hw = pci_get_drvdata(pdev); int i, err, wol = 0; + if (!hw) + return 0; + err = pci_save_state(pdev); if (err) return err; @@ -3830,6 +3833,9 @@ static int skge_resume(struct pci_dev *pdev) struct skge_hw *hw = pci_get_drvdata(pdev); int i, err; + if (!hw) + return 0; + err = pci_set_power_state(pdev, PCI_D0); if (err) goto out; @@ -3868,6 +3874,9 @@ static void skge_shutdown(struct pci_dev *pdev) struct skge_hw *hw = pci_get_drvdata(pdev); int i, wol = 0; + if (!hw) + return; + for (i = 0; i < hw->ports; i++) { struct net_device *dev = hw->dev[i]; struct skge_port *skge = netdev_priv(dev); |