diff options
| author | Nate Case <ncase@xes-inc.com> | 2008-01-29 19:05:09 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-02-03 15:28:41 +0300 |
| commit | 35b5f6b1a82b5c586e0b24c711dc6ba944e88ef1 (patch) | |
| tree | cf08793802ce8f91f13e262c3b6cdcf0a01d95e9 /drivers/net/phy/mdio_bus.c | |
| parent | 2b91213064bd882c3adf35f028c6d12fab3269ec (diff) | |
| download | linux-35b5f6b1a82b5c586e0b24c711dc6ba944e88ef1.tar.xz | |
PHYLIB: Locking fixes for PHY I/O potentially sleeping
PHY read/write functions can potentially sleep (e.g., a PHY accessed
via I2C). The following changes were made to account for this:
* Change spin locks to mutex locks
* Add a BUG_ON() to phy_read() phy_write() to warn against
calling them from an interrupt context.
* Use work queue for PHY state machine handling since
it can potentially sleep
* Change phydev lock from spinlock to mutex
Signed-off-by: Nate Case <ncase@xes-inc.com>
Acked-by: Andy Fleming <afleming@freescale.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/mdio_bus.c')
| -rw-r--r-- | drivers/net/phy/mdio_bus.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index c30196d0ad16..6e9f619c491f 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -49,7 +49,7 @@ int mdiobus_register(struct mii_bus *bus) int i; int err = 0; - spin_lock_init(&bus->mdio_lock); + mutex_init(&bus->mdio_lock); if (NULL == bus || NULL == bus->name || NULL == bus->read || |