diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2019-08-17 13:29:25 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-08-17 22:34:50 +0300 |
| commit | c227ce4423855bddb41a05ad25a93f13b96c89bd (patch) | |
| tree | 7a946bfaf68a1006c41507726a679e37b183cfc1 /drivers/net/phy/dp83822.c | |
| parent | a4d2113e46c1d2ded1bfed9a19fe17b5ab2d584c (diff) | |
| download | linux-c227ce4423855bddb41a05ad25a93f13b96c89bd.tar.xz | |
net: phy: remove calls to genphy_config_init
Supported PHY features are either auto-detected or explicitly set.
In both cases calling genphy_config_init isn't needed. All that
genphy_config_init does is removing features that are set as
supported but can't be auto-detected. Basically it duplicates the
code in genphy_read_abilities. Therefore remove such calls from
all PHY drivers.
v2:
- remove call also from new adin PHY driver
v3:
- pass NULL as config_init function pointer for dp83848
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/dp83822.c')
| -rw-r--r-- | drivers/net/phy/dp83822.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c index 7ed4760fb155..8a4b1d167ce2 100644 --- a/drivers/net/phy/dp83822.c +++ b/drivers/net/phy/dp83822.c @@ -254,13 +254,8 @@ static int dp83822_config_intr(struct phy_device *phydev) static int dp83822_config_init(struct phy_device *phydev) { - int err; int value; - err = genphy_config_init(phydev); - if (err < 0) - return err; - value = DP83822_WOL_MAGIC_EN | DP83822_WOL_SECURE_ON | DP83822_WOL_EN; return phy_write_mmd(phydev, DP83822_DEVADDR, MII_DP83822_WOL_CFG, |