diff options
| author | Don Fry <pcnet32@verizon.net> | 2009-07-31 12:45:29 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-08-02 23:23:06 +0400 |
| commit | 63097b3ad85788a64c75091bff351ecc850761b2 (patch) | |
| tree | ab194f0b2066db0c2b1267539dd40d182596ed7d /drivers/net/pasemi_mac_ethtool.c | |
| parent | df4e7f72f5156ef16a918da8a575ba90ec27ab77 (diff) | |
| download | linux-63097b3ad85788a64c75091bff351ecc850761b2.tar.xz | |
pcnet32: VLB support fixes
VLB support has been broken since at least 2004-2005 period as some
changes introduced back then assumed that ->pci_dev is always valid,
lets try to fix it:
- remove duplicated SET_NETDEV_DEV() call
- call SET_NETDEV_DEV() only for PCI devices
- check for ->pci_dev validity in pcnet32_open()
[ Alternatively we may consider removing VLB support but there would not
be much gain in it since an extra driver code needed for VLB support is
minimal and quite simple. ]
This takes care of the following entry from Dan's list:
drivers/net/pcnet32.c +1889 pcnet32_probe1(298) warning: variable derefenced before check 'pdev'
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Don Fry <pcnet32@verizon.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/pasemi_mac_ethtool.c')
0 files changed, 0 insertions, 0 deletions