diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2009-07-21 15:25:24 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-07-24 05:01:06 +0400 |
| commit | dd93667711761362b393cfbd5959bb11aa1fa80d (patch) | |
| tree | c01896f19458b3fa16722b9322a29f37da552881 /drivers/net/meth.c | |
| parent | 2e76baea67fa74442938afd3417170b28e7aac86 (diff) | |
| download | linux-dd93667711761362b393cfbd5959bb11aa1fa80d.tar.xz | |
net: move meth's probe function to .devinit.text
A pointer to meth_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Christoph Lameter <cl@linux-foundation.org>
Cc: Jeff Garzik <jgarzik@redhat.com>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/meth.c')
| -rw-r--r-- | drivers/net/meth.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/meth.c b/drivers/net/meth.c index abea35de255f..92ceb689b4d4 100644 --- a/drivers/net/meth.c +++ b/drivers/net/meth.c @@ -784,7 +784,7 @@ static const struct net_device_ops meth_netdev_ops = { /* * The init function. */ -static int __init meth_probe(struct platform_device *pdev) +static int __devinit meth_probe(struct platform_device *pdev) { struct net_device *dev; struct meth_private *priv; |