diff options
| author | Alex Elder <elder@linaro.org> | 2022-05-22 03:32:18 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-05-22 22:46:12 +0300 |
| commit | d15180b4eadbdee782d97afcbf3c56e2f246c40a (patch) | |
| tree | 4cbbb5ddfe1e7af61f809bf019a7254e304991df /drivers/net/ipa/ipa_endpoint.c | |
| parent | beb90cba607ff060c325e6717d2d5e7ff58abf11 (diff) | |
| download | linux-d15180b4eadbdee782d97afcbf3c56e2f246c40a.tar.xz | |
net: ipa: kill gsi_trans_commit_wait_timeout()
Since the beginning gsi_trans_commit_wait_timeout() has existed to
provide a way to allow waiting a limited time for a transaction
to complete. But that function has never been used.
In fact, there is no use for this function, because a transaction
committed to hardware should *always* complete. The only reason it
might not complete is if there were a hardware failure, or perhaps a
system configuration error.
Furthermore, if a timeout ever did occur, the IPA hardware would be
in an indeterminate state, from which there is no recovery. It
would require some sort of complete IPA reset, and would require the
participation of the modem, and at this time there is no such
sequence defined.
So get rid of the definition of gsi_trans_commit_wait_timeout(), and
update a few comments accordingly.
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ipa/ipa_endpoint.c')
| -rw-r--r-- | drivers/net/ipa/ipa_endpoint.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 586529511cf6..5ed5b8fd3ea3 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -478,7 +478,6 @@ int ipa_endpoint_modem_exception_reset_all(struct ipa *ipa) ipa_cmd_pipeline_clear_add(trans); - /* XXX This should have a 1 second timeout */ gsi_trans_commit_wait(trans); ipa_cmd_pipeline_clear_wait(ipa); |