diff options
author | Julia Lawall <julia@diku.dk> | 2008-12-21 18:39:15 +0300 |
---|---|---|
committer | Krzysztof Hałasa <khc@pm.waw.pl> | 2008-12-22 03:12:09 +0300 |
commit | 4cb56b685617732733d4d9dffbf8c5a81d4a0c71 (patch) | |
tree | 8e2a0be26a2713b10f0adac145823df59d0102aa /drivers/net/fec_mpc52xx.h | |
parent | 93bc933524d05e3b391358e24b3666599f8ec026 (diff) | |
download | linux-4cb56b685617732733d4d9dffbf8c5a81d4a0c71.tar.xz |
drivers/net/wan: Remove redundant test
arg is checked not to be NULL a few lines before.
A simplified version of the semantic patch that makes this change is as
follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
expression E;
position p1,p2;
@@
if (x@p1 == NULL || ...) { ... when forall
return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
x@p2 == NULL
|
x@p2 != NULL
)
// another path to the test that is not through p1?
@s exists@
local idexpression r.x;
position r.p1,r.p2;
@@
... when != x@p1
(
x@p2 == NULL
|
x@p2 != NULL
)
@fix depends on !s@
position r.p1,r.p2;
expression x,E;
statement S1,S2;
@@
(
- if ((x@p2 != NULL) || ...)
S1
|
- if ((x@p2 == NULL) && ...) S1
|
- BUG_ON(x@p2 == NULL);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
Diffstat (limited to 'drivers/net/fec_mpc52xx.h')
0 files changed, 0 insertions, 0 deletions