diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-02-08 03:23:36 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-02-09 04:57:55 +0400 |
| commit | a584b7ae4ef01425f6827657abdc3e4db49b3578 (patch) | |
| tree | 6bd2487c7c4b6338978c20768c388f2ce9a07699 /drivers/net/ethernet/qlogic | |
| parent | 039055b965b9cfbeacb8cdcd1ef57e18b6374e58 (diff) | |
| download | linux-a584b7ae4ef01425f6827657abdc3e4db49b3578.tar.xz | |
netxen_nic: signedness bug in netxen_md_entry_err_chk()
"esize" should be signed because it can be negative here. For example,
when we call it in netxen_parse_md_template(), it could be -1 from the
return value of netxen_md_L2Cache().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qlogic')
| -rw-r--r-- | drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c index 0a8122851025..6f37470750f3 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c @@ -2354,7 +2354,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter, */ static int netxen_md_entry_err_chk(struct netxen_adapter *adapter, - struct netxen_minidump_entry *entry, u32 esize) + struct netxen_minidump_entry *entry, int esize) { if (esize < 0) { entry->hdr.driver_flags |= NX_DUMP_SKIP; |