diff options
| author | Alexander Duyck <alexander.h.duyck@intel.com> | 2012-05-03 01:19:14 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-05-03 12:21:34 +0400 |
| commit | af94bf6db1d58d26f1cdab145b6312ad363254a6 (patch) | |
| tree | 22956415d73eefa633459df52b554bc8fdffa289 /drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c | |
| parent | 34a802a5b9c4c4efb61828781230805be6dd0f8e (diff) | |
| download | linux-af94bf6db1d58d26f1cdab145b6312ad363254a6.tar.xz | |
ixgbe: Fix use after free on module remove
While testing the TCP changes I had to fix an issue in order to be able to
load and unload the module.
The recent patch that added thermal sensor support added a use after free
bug on module unload with an 82598 adapter in the system. To resolve the
issue I have updated the code so that when we free the info_kobj we set it
back to NULL.
I suspect there are likely other bugs present, but I will leave that for
another patch that can undergo more testing.
I am submitting this directly to net-next since this fixes a fairly serious
bug that will lock up the ixgbe module until the system is rebooted.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c')
| -rw-r--r-- | drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c index aa41fb705469..f81c166dc5a8 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c @@ -185,8 +185,10 @@ static void ixgbe_sysfs_del_adapter(struct ixgbe_adapter *adapter) hwmon_device_unregister(adapter->ixgbe_hwmon_buff.device); #endif /* CONFIG_IXGBE_HWMON */ - if (adapter->info_kobj != NULL) + if (adapter->info_kobj != NULL) { kobject_put(adapter->info_kobj); + adapter->info_kobj = NULL; + } } /* called from ixgbe_main.c */ |