diff options
| author | Sean Anderson <sean.anderson@seco.com> | 2022-09-03 00:57:32 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-09-05 16:27:39 +0300 |
| commit | 901bdff2f529d8a33d9a2b88caa7bfb9fad14c52 (patch) | |
| tree | 0f3e09f8008345f36bf55110b030082111958ffd /drivers/net/ethernet/freescale/fman/fman_tgec.c | |
| parent | aedbeb4e597e9f6202d36e249f1027138a764a67 (diff) | |
| download | linux-901bdff2f529d8a33d9a2b88caa7bfb9fad14c52.tar.xz | |
net: fman: Change return type of disable to void
When disabling, there is nothing we can do about errors. In fact, the
only error which can occur is misuse of the API. Just warn in the mac
driver instead.
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Acked-by: Camelia Groza <camelia.groza@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/fman/fman_tgec.c')
| -rw-r--r-- | drivers/net/ethernet/freescale/fman/fman_tgec.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/net/ethernet/freescale/fman/fman_tgec.c b/drivers/net/ethernet/freescale/fman/fman_tgec.c index 0a66ae58c026..1b60239d5fc7 100644 --- a/drivers/net/ethernet/freescale/fman/fman_tgec.c +++ b/drivers/net/ethernet/freescale/fman/fman_tgec.c @@ -408,19 +408,16 @@ static int tgec_enable(struct fman_mac *tgec) return 0; } -static int tgec_disable(struct fman_mac *tgec) +static void tgec_disable(struct fman_mac *tgec) { struct tgec_regs __iomem *regs = tgec->regs; u32 tmp; - if (!is_init_done(tgec->cfg)) - return -EINVAL; + WARN_ON_ONCE(!is_init_done(tgec->cfg)); tmp = ioread32be(®s->command_config); tmp &= ~(CMD_CFG_RX_EN | CMD_CFG_TX_EN); iowrite32be(tmp, ®s->command_config); - - return 0; } static int tgec_set_promiscuous(struct fman_mac *tgec, bool new_val) |