diff options
| author | Jack Wang <jinpu.wang@cloud.ionos.com> | 2021-02-16 17:38:07 +0300 |
|---|---|---|
| committer | Jason Gunthorpe <jgg@nvidia.com> | 2021-02-17 03:01:56 +0300 |
| commit | ed408529679737a9a7ad816c8de5d59ba104bb11 (patch) | |
| tree | ee39bb3934f28b0fafb4151c8909cce4ae0bb0b3 /drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | |
| parent | 2b5715fc17386a6223490d5b8f08d031999b0c0b (diff) | |
| download | linux-ed408529679737a9a7ad816c8de5d59ba104bb11.tar.xz | |
RDMA/rtrs-srv: Do not pass a valid pointer to PTR_ERR()
smatch gives the warning:
drivers/infiniband/ulp/rtrs/rtrs-srv.c:1805 rtrs_rdma_connect() warn: passing zero to 'PTR_ERR'
Which is trying to say smatch has shown that srv is not an error pointer
and thus cannot be passed to PTR_ERR.
The solution is to move the list_add() down after full initilization of
rtrs_srv. To avoid holding the srv_mutex too long, only hold it during the
list operation as suggested by Leon.
Fixes: 03e9b33a0fd6 ("RDMA/rtrs: Only allow addition of path to an already established session")
Link: https://lore.kernel.org/r/20210216143807.65923-1-jinpu.wang@cloud.ionos.com
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Diffstat (limited to 'drivers/net/ethernet/freescale/dpaa/dpaa_eth.c')
0 files changed, 0 insertions, 0 deletions