diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2016-07-12 03:17:28 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-07-12 05:48:10 +0300 |
| commit | 12c2e32f14da857b58af281b029d4549d24c3292 (patch) | |
| tree | 0dac404657ca43d661cd913925a9e9ecf522ce0e /drivers/net/ethernet/broadcom/bgmac-platform.c | |
| parent | cf81b2ccad03a9477cf3fd135341642420d18620 (diff) | |
| download | linux-12c2e32f14da857b58af281b029d4549d24c3292.tar.xz | |
net: ethernet: bgmac: Fix return value check in bgmac_probe()
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bgmac-platform.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bgmac-platform.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/bgmac-platform.c b/drivers/net/ethernet/broadcom/bgmac-platform.c index 7a8f7effe2a6..1a2d8418e7c1 100644 --- a/drivers/net/ethernet/broadcom/bgmac-platform.c +++ b/drivers/net/ethernet/broadcom/bgmac-platform.c @@ -141,7 +141,7 @@ static int bgmac_probe(struct platform_device *pdev) } bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs); - if (!bgmac->plat.idm_base) { + if (IS_ERR(bgmac->plat.idm_base)) { dev_err(&pdev->dev, "Unable to map idm resource\n"); return PTR_ERR(bgmac->plat.idm_base); } |