diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-04-27 23:30:17 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-04-28 19:45:48 +0300 |
| commit | 66a2f5ef68faaf950746747d790a0c95f7ec96d2 (patch) | |
| tree | 4084c1686802bf159586fca0d1f1267c1547f280 /drivers/net/ethernet/aquantia | |
| parent | f049efc7f7cd2f3c419f55040928eaefb13b3636 (diff) | |
| download | linux-66a2f5ef68faaf950746747d790a0c95f7ec96d2.tar.xz | |
net: enetc: allow tc-etf offload even with NETIF_F_CSUM_MASK
The Time-Specified Departure feature is indeed mutually exclusive with
TX IP checksumming in ENETC, but TX checksumming in itself is broken and
was removed from this driver in commit 82728b91f124 ("enetc: Remove Tx
checksumming offload code").
The blamed commit declared NETIF_F_HW_CSUM in dev->features to comply
with software TSO's expectations, and still did the checksumming in
software by calling skb_checksum_help(). So there isn't any restriction
for the Time-Specified Departure feature.
However, enetc_setup_tc_txtime() doesn't understand that, and blindly
looks for NETIF_F_CSUM_MASK.
Instead of checking for things which can literally never happen in the
current code base, just remove the check and let the driver offload
tc-etf qdiscs.
Fixes: acede3c5dad5 ("net: enetc: declare NETIF_F_HW_CSUM and do it in software")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20220427203017.1291634-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/aquantia')
0 files changed, 0 insertions, 0 deletions