diff options
| author | David Arinzon <darinzon@amazon.com> | 2022-12-29 10:30:09 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-12-30 10:43:44 +0300 |
| commit | c7062aaee099f2f43d6f07a71744b44b94b94b34 (patch) | |
| tree | 3e51fcd562a231d5fbd72791f8be5008e51685ba /drivers/net/ethernet/amazon/ena/ena_ethtool.c | |
| parent | 59811faa2c54dbcf44d575b5a8f6e7077da88dc2 (diff) | |
| download | linux-c7062aaee099f2f43d6f07a71744b44b94b94b34.tar.xz | |
net: ena: Fix rx_copybreak value update
Make the upper bound on rx_copybreak tighter, by
making sure it is smaller than the minimum of mtu and
ENA_PAGE_SIZE. With the current upper bound of mtu,
rx_copybreak can be larger than a page. Such large
rx_copybreak will not bring any performance benefit to
the user and therefore makes no sense.
In addition, the value update was only reflected in
the adapter structure, but not applied for each ring,
causing it to not take effect.
Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Osama Abboud <osamaabb@amazon.com>
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: David Arinzon <darinzon@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/amazon/ena/ena_ethtool.c')
| -rw-r--r-- | drivers/net/ethernet/amazon/ena/ena_ethtool.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/drivers/net/ethernet/amazon/ena/ena_ethtool.c index 48ae6d810f8f..8da79eedc057 100644 --- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c +++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c @@ -887,11 +887,7 @@ static int ena_set_tunable(struct net_device *netdev, switch (tuna->id) { case ETHTOOL_RX_COPYBREAK: len = *(u32 *)data; - if (len > adapter->netdev->mtu) { - ret = -EINVAL; - break; - } - adapter->rx_copybreak = len; + ret = ena_set_rx_copybreak(adapter, len); break; default: ret = -EINVAL; |