diff options
| author | Thomas Graf <tgraf@suug.ch> | 2014-11-27 02:22:33 +0300 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2014-12-15 14:09:20 +0300 |
| commit | d5197164692092d8199b5963204d825ffbdfccec (patch) | |
| tree | ac751887f0daa92ccf74f9c897d0ee9d37649bea /drivers/net/bonding/bond_netlink.c | |
| parent | 678598f3d2f165cd25d82793edf63933f9732a43 (diff) | |
| download | linux-d5197164692092d8199b5963204d825ffbdfccec.tar.xz | |
bond: Check length of IFLA_BOND_ARP_IP_TARGET attributes
commit f6c6fda4c9e17940b0a2ba206b0408babfdc930c upstream.
Fixes: 7f28fa10 ("bonding: add arp_ip_target netlink support")
Reported-by: John Fastabend <john.fastabend@gmail.com>
Cc: Scott Feldman <sfeldma@cumulusnetworks.com>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'drivers/net/bonding/bond_netlink.c')
| -rw-r--r-- | drivers/net/bonding/bond_netlink.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c index 5ab3c1847e67..8626bc0cb2af 100644 --- a/drivers/net/bonding/bond_netlink.c +++ b/drivers/net/bonding/bond_netlink.c @@ -197,7 +197,12 @@ static int bond_changelink(struct net_device *bond_dev, bond_option_arp_ip_targets_clear(bond); nla_for_each_nested(attr, data[IFLA_BOND_ARP_IP_TARGET], rem) { - __be32 target = nla_get_be32(attr); + __be32 target; + + if (nla_len(attr) < sizeof(target)) + return -EINVAL; + + target = nla_get_be32(attr); bond_opt_initval(&newval, (__force u64)target); err = __bond_opt_set(bond, BOND_OPT_ARP_TARGETS, |