diff options
| author | Aaro Koskinen <aaro.koskinen@iki.fi> | 2016-02-20 23:27:48 +0300 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2016-02-24 21:06:46 +0300 |
| commit | 5e64c29e98bfbba1b527b0a164f9493f3db9e8cb (patch) | |
| tree | 9e0d8b236a3060800cc2bde08c74bf9008bb03c3 /drivers/mtd/onenand/onenand_base.c | |
| parent | 3b5394a3ccffbfa1d1d448d48742853a862822c4 (diff) | |
| download | linux-5e64c29e98bfbba1b527b0a164f9493f3db9e8cb.tar.xz | |
mtd: onenand: fix deadlock in onenand_block_markbad
Commit 5942ddbc500d ("mtd: introduce mtd_block_markbad interface")
incorrectly changed onenand_block_markbad() to call mtd_block_markbad
instead of onenand_chip's block_markbad function. As a result the function
will now recurse and deadlock. Fix by reverting the change.
Fixes: 5942ddbc500d ("mtd: introduce mtd_block_markbad interface")
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'drivers/mtd/onenand/onenand_base.c')
| -rw-r--r-- | drivers/mtd/onenand/onenand_base.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index 43b3392ffee7..652d01832873 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd/onenand/onenand_base.c @@ -2599,6 +2599,7 @@ static int onenand_default_block_markbad(struct mtd_info *mtd, loff_t ofs) */ static int onenand_block_markbad(struct mtd_info *mtd, loff_t ofs) { + struct onenand_chip *this = mtd->priv; int ret; ret = onenand_block_isbad(mtd, ofs); @@ -2610,7 +2611,7 @@ static int onenand_block_markbad(struct mtd_info *mtd, loff_t ofs) } onenand_get_device(mtd, FL_WRITING); - ret = mtd_block_markbad(mtd, ofs); + ret = this->block_markbad(mtd, ofs); onenand_release_device(mtd); return ret; } |