diff options
author | Alexander Usyskin <alexander.usyskin@intel.com> | 2016-07-26 01:06:09 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-08-30 15:39:43 +0300 |
commit | e728ae271f4cf71218ec06a6daf61b79466cb466 (patch) | |
tree | e3e4ebd68c9a27c32527b5baa3c41dc0c1e14938 /drivers/misc/mic | |
parent | 80293c47a6774848c72a2f79816b7de1769c5e85 (diff) | |
download | linux-e728ae271f4cf71218ec06a6daf61b79466cb466.tar.xz |
mei: amthif: fix deadlock in initialization during a reset
The device lock was unnecessary obtained in bus rescan work before the
amthif client search. That causes incorrect lock ordering and task
hang:
...
[88004.613213] INFO: task kworker/1:14:21832 blocked for more than 120 seconds.
...
[88004.645934] Workqueue: events mei_cl_bus_rescan_work
...
The correct lock order is
cl_bus_lock
device_lock
me_clients_rwsem
Move device_lock into amthif init function that called
after me_clients_rwsem is released.
This fixes regression introduced by commit:
commit 025fb792bac3 ("mei: split amthif client init from end of clients enumeration")
Cc: <stable@vger.kernel.org> # 4.6+
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/mic')
0 files changed, 0 insertions, 0 deletions