diff options
| author | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2015-04-29 00:34:40 +0300 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-08-04 17:52:06 +0300 |
| commit | 058004b7e7af8761e94edbe0566f164323bba2f2 (patch) | |
| tree | faa4858f87023083ed9c9b0b4719e7ee2a88a2cc /drivers/media | |
| parent | d74d53765b952c03a5b36bcac935bc2c4e313650 (diff) | |
| download | linux-058004b7e7af8761e94edbe0566f164323bba2f2.tar.xz | |
s5h1420: fix a buffer overflow when checking userspace params
commit 12f4543f5d6811f864e6c4952eb27253c7466c02 upstream.
The maximum size for a DiSEqC command is 6, according to the
userspace API. However, the code allows to write up to 7 values:
drivers/media/dvb-frontends/s5h1420.c:193 s5h1420_send_master_cmd() error: buffer overflow 'cmd->msg' 6 <= 7
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'drivers/media')
| -rw-r--r-- | drivers/media/dvb-frontends/s5h1420.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/dvb-frontends/s5h1420.c b/drivers/media/dvb-frontends/s5h1420.c index 93eeaf7118fd..0b4f8fe6bf99 100644 --- a/drivers/media/dvb-frontends/s5h1420.c +++ b/drivers/media/dvb-frontends/s5h1420.c @@ -180,7 +180,7 @@ static int s5h1420_send_master_cmd (struct dvb_frontend* fe, int result = 0; dprintk("enter %s\n", __func__); - if (cmd->msg_len > 8) + if (cmd->msg_len > sizeof(cmd->msg)) return -EINVAL; /* setup for DISEQC */ |