diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-05-08 15:31:00 +0300 |
|---|---|---|
| committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2024-05-10 01:08:09 +0300 |
| commit | b6041c9e9f2d85514358ed478c53dfabd4015e3b (patch) | |
| tree | 00553847bc5a1abed5277270fbc8e0d5a9d8e302 /drivers/media | |
| parent | 0cc50ced282a3236c0cac72f72c6b027beaa2660 (diff) | |
| download | linux-b6041c9e9f2d85514358ed478c53dfabd4015e3b.tar.xz | |
media: bcm2835-unicam: Fix a NULL vs IS_ERR() check
The media_pad_remote_pad_unique() function returns error pointers, not
NULL. Update the check accordingly.
Fixes: 392cd78d495f ("media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/fbbe7862-2820-44eb-81cb-7f33b99cca35@moroto.mountain
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'drivers/media')
| -rw-r--r-- | drivers/media/platform/broadcom/bcm2835-unicam.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c index bdcb04d63338..a1d93c14553d 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -2433,9 +2433,9 @@ static int unicam_async_bound(struct v4l2_async_notifier *notifier, return ret; source = media_pad_remote_pad_unique(sink); - if (!source) { + if (IS_ERR(source)) { dev_err(unicam->dev, "No connected sensor pad\n"); - return -ENOTCONN; + return PTR_ERR(source); } unicam->sensor.subdev = subdev; |