summaryrefslogtreecommitdiff
path: root/drivers/media/video/ov511.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-04-06 09:51:04 +0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2010-05-19 19:56:42 +0400
commite20144770f5a119516f93959eca9818fa5ff065e (patch)
tree491a1b12736c1659a278517df77a38f33779bee8 /drivers/media/video/ov511.c
parentd49f7a240575937703f04d07cf41be1672ce2e25 (diff)
downloadlinux-e20144770f5a119516f93959eca9818fa5ff065e.tar.xz
V4L/DVB: drivers/media/video: avoid NULL dereference
It seems impossible for ov to be NULL at this point. The semantic match that finds the problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ expression E, E1; identifier f; statement S1,S3; iterator iter; @@ if ((E == NULL && ...) || ...) { ... when != false ((E == NULL && ...) || ...) when != true ((E != NULL && ...) || ...) when != iter(E,...) S1 when != E = E1 ( sizeof(E->f) | * E->f ) ... when any return ...; } else S3 // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/ov511.c')
-rw-r--r--drivers/media/video/ov511.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/media/video/ov511.c b/drivers/media/video/ov511.c
index e0bce8dc74bf..dd1b1ac1a0ef 100644
--- a/drivers/media/video/ov511.c
+++ b/drivers/media/video/ov511.c
@@ -5916,11 +5916,6 @@ ov51x_disconnect(struct usb_interface *intf)
mutex_lock(&ov->lock);
usb_set_intfdata (intf, NULL);
- if (!ov) {
- mutex_unlock(&ov->lock);
- return;
- }
-
/* Free device number */
ov511_devused &= ~(1 << ov->nr);