diff options
| author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-10-15 00:00:19 +0400 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-10-15 00:00:19 +0400 |
| commit | d5492fb9ed3f3f25c56b25684072f0d234863b08 (patch) | |
| tree | e880da23a80c996a0b6539accfeaed5d385bc8b1 /drivers/media/video/cx23885 | |
| parent | 97ce5670fcee40b37f75d227ed88dcc51af63140 (diff) | |
| download | linux-d5492fb9ed3f3f25c56b25684072f0d234863b08.tar.xz | |
[media] cx23885: Don't use memset on vidioc_ callbacks
vidioc_g_tuner should not do any memset for the parameters. Core
already does that. In particular, V4L2 core now does some handling
for the tuner type, and the tuner-core module relies on that.
So, doing any memset there is a very bad idea.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/cx23885')
| -rw-r--r-- | drivers/media/video/cx23885/cx23885-video.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/video/cx23885/cx23885-video.c b/drivers/media/video/cx23885/cx23885-video.c index acd6e0c2970e..34854b0a94a5 100644 --- a/drivers/media/video/cx23885/cx23885-video.c +++ b/drivers/media/video/cx23885/cx23885-video.c @@ -1223,7 +1223,6 @@ static int vidioc_g_tuner(struct file *file, void *priv, if (0 != t->index) return -EINVAL; - memset(t, 0, sizeof(*t)); strcpy(t->name, "Television"); return 0; |