summaryrefslogtreecommitdiff
path: root/drivers/media/v4l2-core/videobuf2-vmalloc.c
diff options
context:
space:
mode:
authorJames Hogan <james.hogan@imgtec.com>2014-12-08 19:17:07 +0300
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2014-12-23 21:21:45 +0300
commit983c5bd26b86ba1c0d79b770e596bb8b77e42f32 (patch)
treeeafac29e07884f42b80f12f7ab0fb07062fbb5de /drivers/media/v4l2-core/videobuf2-vmalloc.c
parent40b8a5a65aa3ba51a80f7bd667df8403d54d6e7a (diff)
downloadlinux-983c5bd26b86ba1c0d79b770e596bb8b77e42f32.tar.xz
[media] rc-main: Re-apply filter for no-op protocol change
Since commit da6e162d6a46 ("[media] rc-core: simplify sysfs code"), when the IR protocol is set using the sysfs interface to the same set of protocols that are already set, store_protocols() does not refresh the scancode filter with the new protocol, even if it has already called the change_protocol() callback successfully. This results in the filter being disabled in the hardware and not re-enabled until the filter is set again using sysfs. Fix in store_protocols() by still re-applying the filter whenever the change_protocol() driver callback succeeded. The problem can be reproduced with the img-ir driver by setting a filter, and then setting the protocol to the same protocol that is already set: $ echo nec > protocols $ echo 0xffff > filter_mask $ echo nec > protocols After this, messages which don't match the filter were still being received. Fixes: da6e162d6a46 ("[media] rc-core: simplify sysfs code") Reported-by: Sifan Naeem <sifan.naeem@imgtec.com> Signed-off-by: James Hogan <james.hogan@imgtec.com> Cc: David Härdeman <david@hardeman.nu> Cc: <stable@vger.kernel.org> # v3.17+ Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/v4l2-core/videobuf2-vmalloc.c')
0 files changed, 0 insertions, 0 deletions