summaryrefslogtreecommitdiff
path: root/drivers/media/usb/tm6000/tm6000-alsa.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2012-08-14 18:49:46 +0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-08-16 02:02:27 +0400
commite839776f9dfe1eda232755d5cab6eacc59208b4b (patch)
treec0c3e08fd6d77d429a9c04f49b7ace94965b7b94 /drivers/media/usb/tm6000/tm6000-alsa.c
parent89e47e35685535c16a20dc7b9cf8f969024232bc (diff)
downloadlinux-e839776f9dfe1eda232755d5cab6eacc59208b4b.tar.xz
[media] drivers/media/usb/{s2255drv.c, tm6000/tm6000-alsa.c, tm6000/tm6000-input.c}: Remove potential NULL dereferences
If the NULL test is necessary, the initialization involving a dereference of the tested value should be moved after the NULL test. The sematic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/usb/tm6000/tm6000-alsa.c')
-rw-r--r--drivers/media/usb/tm6000/tm6000-alsa.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/usb/tm6000/tm6000-alsa.c b/drivers/media/usb/tm6000/tm6000-alsa.c
index bd07ec707956..813c1ec53608 100644
--- a/drivers/media/usb/tm6000/tm6000-alsa.c
+++ b/drivers/media/usb/tm6000/tm6000-alsa.c
@@ -487,10 +487,11 @@ error:
static int tm6000_audio_fini(struct tm6000_core *dev)
{
- struct snd_tm6000_card *chip = dev->adev;
+ struct snd_tm6000_card *chip;
if (!dev)
return 0;
+ chip = dev->adev;
if (!chip)
return 0;