diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2019-09-24 12:49:04 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2019-10-07 13:51:17 +0300 |
| commit | 649cd16c438f51d4cd777e71ca1f47f6e0c5e65d (patch) | |
| tree | 76be8bf5e14fbc1f88f2dd98eae5df7faeac9354 /drivers/media/usb/b2c2 | |
| parent | 43be77fa6ce6907d285269bf98e654ad21a36880 (diff) | |
| download | linux-649cd16c438f51d4cd777e71ca1f47f6e0c5e65d.tar.xz | |
media: flexcop-usb: fix NULL-ptr deref in flexcop_usb_transfer_init()
If usb_set_interface() failed, iface->cur_altsetting will
not be assigned and it will be used in flexcop_usb_transfer_init()
It may lead a NULL pointer dereference.
Check usb_set_interface() return value in flexcop_usb_init()
and return failed to avoid using this NULL pointer.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/usb/b2c2')
| -rw-r--r-- | drivers/media/usb/b2c2/flexcop-usb.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/media/usb/b2c2/flexcop-usb.c b/drivers/media/usb/b2c2/flexcop-usb.c index 1826ff825c2e..4bf85e9b78b8 100644 --- a/drivers/media/usb/b2c2/flexcop-usb.c +++ b/drivers/media/usb/b2c2/flexcop-usb.c @@ -504,7 +504,13 @@ urb_error: static int flexcop_usb_init(struct flexcop_usb *fc_usb) { /* use the alternate setting with the larges buffer */ - usb_set_interface(fc_usb->udev,0,1); + int ret = usb_set_interface(fc_usb->udev, 0, 1); + + if (ret) { + err("set interface failed."); + return ret; + } + switch (fc_usb->udev->speed) { case USB_SPEED_LOW: err("cannot handle USB speed because it is too slow."); |