diff options
| author | Ming Qian <ming.qian@nxp.com> | 2022-02-07 09:28:43 +0300 |
|---|---|---|
| committer | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2022-02-22 11:41:12 +0300 |
| commit | 97558d170a1236280407e8d29a7d095d2c2ed554 (patch) | |
| tree | e67d4cc08b20134889a0774c11f19e605ed1ad73 /drivers/media/platform/imx-jpeg/mxc-jpeg.c | |
| parent | adccfff098f59f47cbf4bcbfdf8732832419dcaf (diff) | |
| download | linux-97558d170a1236280407e8d29a7d095d2c2ed554.tar.xz | |
media: imx-jpeg: fix a bug of accessing array out of bounds
When error occurs in parsing jpeg, the slot isn't acquired yet, it may
be the default value MXC_MAX_SLOTS.
If the driver access the slot using the incorrect slot number, it will
access array out of bounds.
The result is the driver will change num_domains, which follows
slot_data in struct mxc_jpeg_dev.
Then the driver won't detach the pm domain at rmmod, which will lead to
kernel panic when trying to insmod again.
Signed-off-by: Ming Qian <ming.qian@nxp.com>
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Diffstat (limited to 'drivers/media/platform/imx-jpeg/mxc-jpeg.c')
| -rw-r--r-- | drivers/media/platform/imx-jpeg/mxc-jpeg.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/imx-jpeg/mxc-jpeg.c index 77c5134739ea..4a79112a6fd1 100644 --- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c @@ -954,7 +954,6 @@ static void mxc_jpeg_device_run(void *priv) jpeg_src_buf->jpeg_parse_error = true; } if (jpeg_src_buf->jpeg_parse_error) { - jpeg->slot_data[ctx->slot].used = false; v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx); v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx); v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_ERROR); |